eclipse-tractusx / tractus-x-umbrella

Where all Tractus-X comes together
Apache License 2.0
12 stars 24 forks source link

Change edc-miw-keycloak-secret in tx-data-provider #130

Closed evegufy closed 3 weeks ago

evegufy commented 1 month ago

Description

The name suggests that the secret / secret alias is the client secret in centralidp Keycloak when using the Managed Identity Wallet (MIW).

https://github.com/eclipse-tractusx/tractus-x-umbrella/blob/umbrella-1.0.0/charts/tx-data-provider/values.yaml#L36 https://github.com/eclipse-tractusx/tractus-x-umbrella/blob/umbrella-1.0.0/charts/tx-data-provider/templates/post-install-vault-setup.yaml#L58

This can be confusing because, since since R2405, MIW is no longer the wallet, see note for more information.

It should be renamed because we use it now with together with the IATP mock and the SSI DIM Wallet Stub.

I suggest to rename it to edc-wallet-secret.