eclipse-tractusx / tractus-x-umbrella

Apache License 2.0
10 stars 23 forks source link

Update helm-test post install #159

Open matbmoser opened 1 day ago

matbmoser commented 1 day ago

Task

Relates to https://github.com/eclipse-tractusx/tractus-x-umbrella/issues/134 and https://github.com/eclipse-tractusx/tractus-x-umbrella/pull/153

evegufy commented 1 day ago

it's not about some test that is failing, it's about a failing post install job which is supposed to be importing/seeding the test data https://github.com/eclipse-tractusx/tractus-x-umbrella/tree/umbrella-2.0.2/charts/tx-data-provider/resources

kss682 commented 1 day ago
  File "/opt/scripts/upload.py", line 253, in create_registry_asset
    print_response(response_)
Policy default-policy already exists. Skipping creation.
Create policy test on EDC http://umbrella-dataprovider-edc-controlplane:8081/management/v2/policydefinitions
<Response [409]>
[{"message":"Policy with ID test already exists","type":"ObjectConflict","path":null,"invalidValue":null}]
http://umbrella-dataprovider-edc-controlplane:8084
http://umbrella-dataprovider-edc-controlplane:8081
Query Catalog for registry asset http://umbrella-dataprovider-edc-controlplane:8081/management/v2/catalog/request
<Response [500]>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 500 Internal Server Error</title>
</head>
<body><h2>HTTP ERROR 500 Internal Server Error</h2>
<table>
<tr><th>URI:</th><td>/management/v2/catalog/request</td></tr>
<tr><th>STATUS:</th><td>500</td></tr>
<tr><th>MESSAGE:</th><td>Internal Server Error</td></tr>
<tr><th>SERVLET:</th><td>EDC-management</td></tr>
</table>

</body>
</html>

  File "/opt/scripts/upload.py", line 168, in print_response
    raise Exception("Failed to call service")
Exception: Failed to call service

The error on the post install job

kss682 commented 1 day ago

For the catalog request payload. The only difference I could see is, missing key "@type". catalog doc 0.7.3 code

evegufy commented 22 hours ago

@kss682 hadn't seen that log yet, I get the helm test point in the context of the post install job now. I noticed another thing, not sure if relevant:

For some reason, I can't find the catalog request endpoint in 0.7.3 and once it's available again - from 0.7.4 onwards - it's v3, not v2 (as in 0.7.1) anymore ... 0.7.7

Maybe it's worth checking the versions of all endpoints here

kss682 commented 5 hours ago

@evegufy @matbmoser

Query Catalog for registry asset http://umbrella-dataprovider-edc-controlplane:8081/management/v3/catalog/request
<Response [500]>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 500 Internal Server Error</title>
</head>
<body><h2>HTTP ERROR 500 Internal Server Error</h2>
<table>
<tr><th>URI:</th><td>/management/v3/catalog/request</td></tr>
<tr><th>STATUS:</th><td>500</td></tr>
<tr><th>MESSAGE:</th><td>Internal Server Error</td></tr>
<tr><th>SERVLET:</th><td>EDC-management</td></tr>
</table>

</body>

The issue persists even after changing it to v3. It seems like the issue is because of the this breaking change https://github.com/eclipse-edc/Connector/pull/4185

evegufy commented 5 hours ago

Hi @kss682 thank you for testing v3, I was just guessing.

Do you need support for upgrading the post install job for seeding the test data to the breaking change?

If so, I'm not so deep into EDC stuff. @matbmoser can you or @saudkhan116 support here? If not, there are also some other committers we could ask, I think.

kss682 commented 4 hours ago

@evegufy I was reading into the commit, not sure if this would be the only change. "edc:operandLeft": "https://w3id.org/edc/v0.0.1/ns/type" to "edc:operandLeft": {"@id": "https://w3id.org/edc/v0.0.1/ns/type"} in here. All such occurrences would need to be changed.