eclipse-tractusx / tractusx-edc

Apache License 2.0
35 stars 51 forks source link

Helm charts: take API keys from Vault by default #1337

Open paullatzelsperger opened 1 month ago

paullatzelsperger commented 1 month ago

WHAT

Our Helm charts should default to taking API keys (Management API, Consumer Proxy API) from the Vault using an alias, and only use raw values as fallback.

For example, for the Management API key, this would look roughly like this (pseudocode):

{{- if  .Values.controlplane.endpoints.management.apiKey }}
- name: "EDC_API_AUTH_KEY"
  value: {{ .Values.controlplane.endpoints.management.apiKey }}

{{- else if .Values.controlplane.endpoints.management.apiKeyAlias }}
- name: "EDC_API_AUTH_KEY_ALIAS"
  value: {{ .Values.controlplane.endpoints.management.apiKeyAlias }}

{{- else }}

{{- required "Must either provider an API key or an API key alias!" "" }}

{{- end}}

WHY

Providing hard-coded API keys is not a great idea for several reasons:

HOW

// if possible, outlines a solution proposal

FURTHER NOTES

// anything else you want to outline

_Please be sure to take a look at our contribution guidelines and our PR etiquette._

github-actions[bot] commented 4 days ago

This issue is stale because it has been open for 4 weeks with no activity.