laeubi
commented
2 years ago @nitind can you provide an integration-test to demonstrate the issue or example project?
Closed nitind closed 2 years ago
laeubi
commented
2 years ago @nitind can you provide an integration-test to demonstrate the issue or example project?
michaelcompressconsult
commented
2 years ago same with 2.7.4, java 11.3. 12:12:07 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:2.7.4:package-feature (default-package-feature) on project xxxx.feature: Execution default-package-feature of goal org.eclipse.tycho:tycho-packaging-plugin:2.7.4:package-feature failed: basedir /var/workspace/workspace/.../xxxx.feature/target/classes does not exist -> [Help 1]
this is a feature in a java project that contains just a feature.xml; there is no target.classes path in workspace as the plugins are compiled elsewhere. i also tried explicitely configuring basedir:
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-packaging-plugin</artifactId>
<configuration>
<basedir>${project.basedir}</basedir>
</configuration>
</plugin>but it is still mentioning .../target/classes in the error message.
might be related to buggy update-consumer-pom - see https://www.eclipse.org/tycho/sitedocs/tycho-packaging-plugin/update-consumer-pom-mojo.html as adding
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-packaging-plugin</artifactId>
<configuration>
<skipPomGeneration>true</skipPomGeneration>
</configuration>
</plugin>still shows in output: 12:32:18 [INFO] --- flatten-maven-plugin:1.2.7:flatten (flatten_pom) @ xxxxx.feature --- 12:32:18 [INFO] Generating flattened POM of project xxxxx.feature:eclipse-feature:24.0.1.08... 12:32:18 [INFO] 12:32:18 [INFO] --- tycho-packaging-plugin:2.7.4:update-consumer-pom (default-update-consumer-pom) @ xxxxx.feature --- 12:32:18 [INFO] 12:32:18 [INFO] --- tycho-packaging-plugin:2.7.4:package-feature (default-package-feature) @ xxxxx.feature ---
even binding the goal update-consumer-pom to phase none showed the phase to be run in the log
laeubi
commented
2 years ago flatten-maven-plugin:1.2.7:flatten (flatten_pom)
please note that flatten-maven-plugin:flatten != tycho-packaging:update-consumer-pom
michaelcompressconsult
commented
2 years ago read one line further - gust wanted to show i use the flatten plugin. 12:32:18 [INFO] --- tycho-packaging-plugin:2.7.4:update-consumer-pom (default-update-consumer-pom) @ xxxxx.feature ---
laeubi
commented
2 years ago read one line further - gust wanted to show i use the flatten plugin.
The mojo is always executed because it is part of the tycho-lifecycle but skipped if you ask for it see
michaelcompressconsult
commented
2 years ago reviewed code there, looks ok.
laeubi
commented
2 years ago reviewed code there, looks ok.
That's why I asked for an integration-test to demonstrate the issue, its usually easier to see whats going on then if one has a minimal example.
michaelcompressconsult
commented
2 years ago checked location. https://github.com/eclipse/tycho/blob/f2b46160a4f7dd70641767778f41bcd35e024594/tycho-packaging-plugin/src/main/java/org/eclipse/tycho/packaging/PackagePluginMojo.java#L239:~:text=//%203.%20handle%20nested,%5B0%5D))%3B problem is that my feature does not have any "nested jars and included resources" (basically just a feature.xml in the rootdir), so the directory the packaging misses is not created. Of course i can add an empty directory to version control, but do i really need to?
2.7.1 works for me.
nitind
commented
2 years ago That's why I asked for an integration-test to demonstrate the issue, its usually easier to see whats going on then if one has a minimal example.
I agree, however as I have no idea what's causing this regression, I don't know how to trigger it on purpose beyond "here's a large public repository we've been building for years where behavior is now broken."
laeubi
commented
2 years ago That's why I asked for an integration-test to demonstrate the issue, its usually easier to see whats going on then if one has a minimal example.
I agree, however as I have no idea what's causing this regression, I don't know how to trigger it on purpose beyond "here's a large public repository we've been building for years where behavior is now broken."
Usually one can take the large repo and try to reduce it e.g.:
laeubi
commented
2 years ago By the way there was a fix here that sounds similar: https://github.com/eclipse-tycho/tycho/commit/0eb720ef75edc7f125b55f4c6e6fcf92e5714c6c
So please try out the current tycho snapshot build to check if the problem is fixed there.
nitind
commented
2 years ago By the way there was a fix here that sounds similar: 0eb720e
So please try out the current tycho snapshot build to check if the problem is fixed there.
The 2.7.5 release, which I think has this change, seems to no longer have the problem. I'm updating all of my build jobs to 2.7.5 to make sure.
laeubi
commented
2 years ago Yes the fix is part of Tycho 2.7.5
nitind
commented
2 years ago Confirmed, my jobs are all running properly with 2.7.5.
2.7.2 and 2.7.3 seem to fail when building some of my features and doc plug-ins, assuming that they should have compiled classes in a folder. Building with 2.7.1 succeeds.
Full trace on a doc plug-in (https://git.eclipse.org/c/servertools/webtools.servertools.git/tree/docs/org.eclipse.jst.server.ui.doc.user/pom.xml) failure, built with apache-maven-3.8.5, openjdk version "17.0.3" 2022-04-19, and Tycho 2.7.2 and 2.7.3: