Open mdaloia opened 4 months ago
Can you provide an integration-test to demonstrate the issue from your example with proper assertions? Then it is easy to verify it worked (differently) in 2.7.x and we can make sure if there is a fix that it does not break in the future again.
By the way is there a reason you are not using fix-artifacts-metadata instead of this quite complicated steps?
Can you provide an integration-test to demonstrate the issue from your example with proper assertions?
Sure, I will try to add an IT later.
By the way is there a reason you are not using fix-artifacts-metadata instead of this quite complicated steps?
We tried to use that goal, but we are impacted by this other issue https://github.com/eclipse-tycho/tycho/issues/2875 because we are using an standalone
director which uses and old p2 director and it compares the MD5 and as we need to re-sign some .jar files it fails.
Why we are using the standalone
instead of the internal
? because we have custom touchpoints and using the internal
director fails when a product
is being materialized as it seems it doesn't found it.
The goal
publish-features-and-bundles
reuses the metadata available in the reactor when source and destination repository are the same location andappend
is used, even if you, before calling this goal, delete theartifacts.*
andcontent.*
files in repository. If you do a modification that changes some metadata it keeps the old value.This seems to be working as the Eclipse standalone application for 4.31 using the
append
with the same destination as the source. The difference is that it keeps old metadata only if you DON'T delete theartifacts.*
andcontent.*
files before calling it.Previously, in Tycho 2.7.5, this goal recreated the metadata only with the size and checksums properties.
In Tycho 4.0.7, it seems that the metadata information present somewhere in the reactor context is being "leaked" to the new metadata.
Example:
artifacts.*
andcontent.*
filespublish-features-and-bundles
goalIf you run those steps as part of the same Maven execution the issue surfaces. If 1,2,3 and 4 are run in one Maven execution and 5 in another (could be implemented via Maven profiles) then we get an output like 2.7.5.
Example pom.xml
Changing just the `tycho.version` property to `2.7.5` it works. ```xmlExample run
### Run the build ![image](https://github.com/eclipse-tycho/tycho/assets/1738654/07689ecb-dabe-4ff4-8c90-eb1bce6c6402) ### Compare the SHA-256 ![image](https://github.com/eclipse-tycho/tycho/assets/1738654/bbaeae5a-ccd0-4f30-9f77-62c003c99066)