Validation Rules

[eclipse-uml2-bot]

| --- | --- | | Bugzilla Link | 80307 | | Status | NEW | | Importance | P3 enhancement | | Reported | Dec 06, 2004 15:45 EDT | | Modified | Apr 15, 2016 05:11 EDT | | Version | 1.1.0 | | Depends on | 321605 | | Blocks | 402806 | | Reporter | Kenn Hussey |

Description

Complete the generation and implementation of validation rules from the UML 2.0 \ source model.

[eclipse-uml2-bot]

By Kenn Hussey on Feb 16, 2006 16:25

Bug 128266 has been marked as a duplicate of this bug.

[eclipse-uml2-bot]

By James Bruck on Mar 08, 2006 13:56

Created attachment 35921 ported existing validation rules from old api to new

Patch for some of validation rules ... more to come.

:notepad_spiral: validationPatch1.txt

[eclipse-uml2-bot]

By James Bruck on Mar 15, 2006 10:30

Created attachment 36338 (attachment deleted)\ additional validation rules

additional validation rules

[eclipse-uml2-bot]

By James Bruck on Mar 24, 2006 16:17

Comment on attachment 36338 (attachment deleted)\ additional validation rules

modified

[eclipse-uml2-bot]

By James Bruck on Mar 24, 2006 16:18

Created attachment 36914 more validation rules

:notepad_spiral: validationPatch_060324.txt

[eclipse-uml2-bot]

By Kenn Hussey on Mar 28, 2006 13:27

The changes from attachment 3 have been committed (with modifications).

[eclipse-uml2-bot]

By James Bruck on Mar 28, 2006 15:05

Created attachment 37131 (attachment deleted)\ patches for Behavior and Interface

Patch for Behavior and Interface

[eclipse-uml2-bot]

By James Bruck on Mar 28, 2006 17:23

Created attachment 37153 combined patch for operation, behavior, port

combined patch for operation, behavior, port

:notepad_spiral: validationPatch_060328.txt

[eclipse-uml2-bot]

By James Bruck on Mar 29, 2006 12:05

Created attachment 37217 Patch for profile and package

:notepad_spiral: validationPatch_060329.txt

[eclipse-uml2-bot]

By James Bruck on Mar 29, 2006 15:39

Created attachment 37236 combinedFragment and ExecutionSpecification

:notepad_spiral: validationPatch_060329_1.txt

[eclipse-uml2-bot]

By James Bruck on Mar 31, 2006 10:35

Created attachment 37419 MessageOperations

:notepad_spiral: validationPatch_060331.txt

[eclipse-uml2-bot]

By Kenn Hussey on Apr 05, 2006 17:09

The changes from attachment 37153, attachment 37217, attachment 37236 and attachment 37419 have been committed to CVS.

The remainder of the validation rules will be implemented in a future release i.e. 2.1).

[eclipse-uml2-bot]

By James Bruck on May 08, 2006 10:19

Created attachment 40586 connectorOperations validation rules updated

:notepad_spiral: validationPatch_060508.txt

[eclipse-uml2-bot]

By James Bruck on May 12, 2006 14:00

Created attachment 41343 validation patch for extension ends

:notepad_spiral: validationPatch_ExtensionEnd_060512.patch

[eclipse-uml2-bot]

By Kenn Hussey on May 14, 2007 09:51

Deferring to a future release.

[eclipse-uml2-bot]

By Javier Muñoz on Nov 29, 2007 05:55

Created attachment 84050 patch that implements several validations

This patch some implements validations in several elements (Actor, Association, InitialNode, Parameter, etc.)

:notepad_spiral: validations-UML2.patch

[eclipse-uml2-bot]

By Kenn Hussey on Dec 04, 2007 11:16

Thanks for the contribution, Javier! James will look into having these changes committed (pending IP review) as soon as possible.

[eclipse-uml2-bot]

By James Bruck on Dec 04, 2007 18:34

The patch is under review now.

[eclipse-uml2-bot]

By Javier Muñoz on Dec 05, 2007 06:44

I am very happy to have the chance of contributing to this so exciting project. So I'm willing to provide more patches implementing validations in the future.

I don't know if this is the most suitable place to ask but, is there any plan to use in the future the OCL compiler that is (or will be) provided by the OCLTools project (http://wiki.eclipse.org/OCLTools)?

[eclipse-uml2-bot]

By James Bruck on Dec 06, 2007 11:45

Thanks for the contribution!

Some general comments:

• code can be compressed in some areas for example in MergeNodeOperations..

  boolean isValid = true;\ isValid = mergeNode.getOutgoings().size() == 1;\ if (!isValid) {}

• In UseCaseOperations, I don't believe there is a need for the following:

  Proposed: \ List assocList = new ArrayList();\ if (useCase.getAssociations() != null) {\ assocList.addAll(useCase.getAssociations());\ }

  for (Association association : assocList) {
  
  I believe the original is ok since null is not returned.
  
  Original:\

  for (Association association : useCase.getAssociations()) {

• The customized UML code formatter could be used to make consistent use of indentation.

Looks good!

I will create an update with suggested 'tweaks' and we can discuss further.

[eclipse-uml2-bot]

By James Bruck on Dec 12, 2007 15:11

Created attachment 85114 Update for ActorOperations

:notepad_spiral: Validation_ActorOperations.patch

[eclipse-uml2-bot]

By James Bruck on Dec 12, 2007 15:13

Created attachment 85115 Update for ActivityEdgeOperations

source or target could be owned by an activity node within some activity.

:notepad_spiral: Validation_ActivityEdgeOperations.patch

[eclipse-uml2-bot]

By James Bruck on Dec 12, 2007 16:55

Created attachment 85127 Update for AssociationOperations

re-wrote the validation rules to match OCL more closely.

:notepad_spiral: Validation_AssociationOperations.patch

[eclipse-uml2-bot]

By James Bruck on Dec 12, 2007 17:05

Hi Javier,

Please have a look at the suggested alternative patches for ActorOperations, ActivityEdgeOperations and AssociationOperations.

• James.

[eclipse-uml2-bot]

By Javier Muñoz on Dec 17, 2007 06:36

Thank you for reviewing the code. Your modifications clearly improve it. Nothing to say by my side, but thank you.

Javier.

[eclipse-uml2-bot]

By Javier Muñoz on Apr 24, 2008 09:46

Hi! Any plan to commit soon the new validations in the CVS?

[eclipse-uml2-bot]

By James Bruck on Apr 24, 2008 10:15

Hi Javier,

As it stands, the patch you created cannot be committed because it is incomplete and requires more work.

I had made some updates to your patch (for ActorOperations, ActivityEdgeOperations and AssociationOperations) but the remainder of your original patch needs to be updated before I can commit it.

Please resubmit your patch with updates to the remaining validation rules so that they more closely match the code style that already exists.\ Also please double check the correctness of the remaining validation rules that you submitted as some of them are incomplete.

Use the 3 updates that I submitted as suggestions on re-writting the remaining ones.

I'll be happy to commit the patch once it is updated.

Cheers,

• James.

[eclipse-uml2-bot]

By Ansgar Radermacher on Mar 09, 2013 06:47

Created attachment 228168 Patch for class RegionOperations

A small patch that implements validation rules for regions

:notepad_spiral: org.eclipse.uml2.uml.diff

[eclipse-uml2-bot]

By Kenn Hussey on Mar 09, 2013 08:52

(In reply to comment #28)

Created attachment 228168 [details] Patch for class RegionOperations

A small patch that implements validation rules for regions

Thanks for the contribution! I'll look into committing these changes immediately following M6.

[eclipse-uml2-bot]

By Kenn Hussey on Mar 20, 2013 17:58

(In reply to comment #29)

(In reply to comment #28)

Created attachment 228168 [details] Patch for class RegionOperations

A small patch that implements validation rules for regions

Thanks for the contribution! I'll look into committing these changes immediately following M6.

OK, I've committed/pushed changes to the 'master' branch in git. Note that I didn't apply the patch as-is because it was missing custom messages (which all of the other implemented validation rules have) and needed to be formatted to be consistent with UML2 style conventions. Ansgar, please take those into account should you consider submitting implementations for other constraints in the future. Thanks!