search

eclipse-uprotocol / up-cpp

uProtocol Language Specific Library for C++
Apache License 2.0
17 stars 25 forks source link

Builder umessage #146

Closed ruchirchauhan closed 3 months ago

ruchirchauhan commented 4 months ago

This PR implements builder for UMessage

ruchirchauhan commented 4 months ago

Since this build creates a message with empty payload and just attributes, there are not many tests that we need to do on it but it would make sense to add one more test , that tests the actual message been built for correct attributes.

billpittman commented 4 months ago

@ruchirchauhan For the sake of our maintainers, would you put a comment/reference in the description about how/why this PR should be merged after that-PR-link.

gregmedd commented 3 months ago

@ruchirchauhan - it looks like #161 is almost ready to merge. Once that's in, you should be able to rebase and we can (hopefully) wrap up this PR too.

gregmedd commented 3 months ago

@ruchirchauhan - PR #161 has been merged, so you should be able to use the PayloadBuilder now. Please rebase onto main to get the latest changes.