search

eclipse-uprotocol / up-java

uProtocol Language Specific Library for Java
Apache License 2.0
8 stars 14 forks source link

InMemorySubscriber should specify what version of the subscription protobuf it is working with #155

Closed tamarafischer closed 2 months ago

tamarafischer commented 2 months ago

Currently we have version 2 and version 3 of the subscription protobuf. version 2 is the one actually used, as of typing this issue. I am not sure who is using version 3.

InMemorySubscriber should specify the version or maybe have 2 versions of Subscriber, otherwise we might have problems understanding the payload.

stevenhartley commented 2 months ago

InMemorySubscriber is based off UTransport that is based off UMessages that are a part of 1.6.0 of uProtocol that will only be using in deployments that have v3 or later of uSubscription as v2 is not using Eclipse-uProtocol but the older closed source version of uProtocol. That being said, we do need to consider supporting updated versions of the proto in the future (when we go from v3 to v4 whenever that might happen).

stevenhartley commented 2 months ago

This is addressed by #148 and the PR #158 .