search

eclipse-uprotocol / up-rust

uProtocol Language Specific Library for Rust
Apache License 2.0
11 stars 9 forks source link

Core Rust Library Support #10

Closed stevenhartley closed 9 months ago

stevenhartley commented 9 months ago

uProtocol core library written in Rust

PLeVasseur commented 9 months ago

Hi @stevenhartley, had a question for you --

Does this entail implementation of the APIs for all the protobuf specs in here according to the uprotocol-spec repo? Or some subset?

Perhaps we could break this issue up into the pieces to implement and prioritize them so folks know where to pick up work at and allow us to close out finished work.

What do you think?

Cheers, Pete

stevenhartley commented 9 months ago

This is to implement https://github.com/eclipse-uprotocol/uprotocol-spec/blob/main/languages.adoc so the language SDK, not the platform.

PLeVasseur commented 9 months ago

Gotcha! Thanks for the pointer.

sophokles73 commented 9 months ago

@stevenhartley is there any criteria for when this issue could/should be closed? Given that the initial code has been merged, I would propose to close this issue and improve the code based on additional issues/PRs.

BTW the definitions made in https://github.com/eclipse-uprotocol/uprotocol-spec/blob/main/languages.adoc seem to be quite strict, e.g. when it comes to source code layout and distribution of functionality. Apart from trying to provide a comparable UX between the different SDKs, is there any particular reason for maintaining these requirements? In the Rust SDK we have already broken some of the requirements by eliminating the serializer module for UUIDs and I intend to remove the corresponding validator module as well (#13) ...

WDYT?

stevenhartley commented 9 months ago

Yes we can close and add issues for follow on work.

For the language spec, the goal mainly was for functionality (to make sure the functionality is there and less on the UX) but I see what you mean for how it reads. I'm OK to loosen the requirements if they are hindering you from optimizing the implementation in Rust.