search

eclipse-uprotocol / up-rust

uProtocol Language Specific Library for Rust
Apache License 2.0
11 stars 9 forks source link

Remove UPayload #108

Closed AnotherDaniel closed 4 months ago

AnotherDaniel commented 4 months ago

Following up-spec #145, remove UPayload from the rust library. This let's us get rid of RpcMapper entirely, which is nice. For now I did not 'save' the RpcMapper::pack_any() and RpcMapper::unpack_any() methods, because they are not needed anywhere I can see and also have little to do with the actual uProtocol scope. Shout if you're missing them nonetheless!

sophokles73 commented 4 months ago

Just one question: Should we pin at a specific commit of up-spec instead of main in build.rs? When the up-spec (up-core-api) changes, it'll break the up-rust and affect other libraries depending on up-rust.

Actually, that is the main intention of referring to up-spec/main, i.e. we want to see that things have changed and we need to adapt up-rust ...

sophokles73 commented 4 months ago

@evshary Would you mind taking a look at the changes that I have pushed in addition to Daniel's original PR? @AnotherDaniel is on vacation this week and we agreed to get this merged this week ...

sophokles73 commented 4 months ago

@evshary can you check if this (still) works for you?

evshary commented 4 months ago

@evshary can you check if this (still) works for you?

Yes, I give my pass to it.