search

eclipse-uprotocol / up-rust

uProtocol Language Specific Library for Rust
Apache License 2.0
11 stars 9 forks source link

Fix USubscription doc tests #98

Closed sophokles73 closed 4 months ago

sophokles73 commented 5 months ago

The doc tests had not been updated yet to reflect the changes introduced to the UTransport trait's functions for matching on source and sink address patterns.

sophokles73 commented 4 months ago

LGTM

@sophokles73 -- does that mean the doc tests didn't catch this and fail the build when the UTransport::register_listener() change went in?

At least not as part of the tests we run in our standard CI build. That is because that standard build does not activate the usubscription feature, but the nightly build does :-)

AnotherDaniel commented 4 months ago

This is interesting insofar as I'd expect the --all-features flag to enable, well, all features?

sophokles73 commented 4 months ago

This is interesting insofar as I'd expect the --all-features flag to enable, well, all features?

@AnotherDaniel Doc tests are not (yet) supported in cargo nextest: https://github.com/nextest-rs/nextest/issues/16

Maybe you can add an extra cargo test --doc step to the corresponding job?