search

eclipse-uprotocol / up-spec

uProtocol Specifications
Apache License 2.0
32 stars 25 forks source link

Update UTransport interface specification #134

Closed sophokles73 closed 3 months ago

sophokles73 commented 4 months ago

Changed registerListener method signature to support matching on message source and sink addresses by means of UUri patterns.

This change allows UTransport to be used by higher level APIs for implementing all message exchange patterns supported by uProtocol.

Fixes #73

sophokles73 commented 4 months ago

@stevenhartley @PLeVasseur I have pushed changes and have amended your comments ...

matthewd0123 commented 4 months ago

Question/comment. Can/should we also align the error messages returned as well? Good that we're aligning the UCodes, but would ask if it's worth it to align the UStatus messages as well between implementations. Benefit would be consistency, but not sure if it's too much micromanagement.

sophokles73 commented 4 months ago

Question/comment. Can/should we also align the error messages returned as well? Good that we're aligning the UCodes, but would ask if it's worth it to align the UStatus messages as well between implementations. Benefit would be consistency, but not sure if it's too much micromanagement.

FMPOV relying on error message format/content is an antipattern that leads to code that is hard to maintain and will produce hard to find bugs during runtime. So, no, I do not think that we should standardize error messages ...

sophokles73 commented 4 months ago

@stevenhartley @PLeVasseur I have pushed changes as discussed in the call. Would you mind taking another look?

@tamarafischer I have tried to add some wording to the expected outcome of the send() method. WDYT?

PLeVasseur commented 4 months ago

Would you mind taking another look?

Changes to the section we discussed on the call look good to me!

sophokles73 commented 3 months ago

@stevenhartley I have accepted your proposed changes but in order to merge the PR, GitHub still requires your explicit approval ...