search

eclipse-uprotocol / up-spec

uProtocol Specifications
Apache License 2.0
32 stars 25 forks source link

Remove uPayload #145

Closed stevenhartley closed 4 months ago

stevenhartley commented 4 months ago

The following change removes the unused UPayload protobuf object and places the format in UAttributes.

144

gregmedd commented 4 months ago

This looks like an otherwise minor change to the structure of a message that has fairly large implications for the APIs we are building. For example, this will require non-trivial changes to the up-cpp API update we just reviewed and approved yesterday as it completely changes the interaction model for message data.

It also removes the possibility of extending the UPayload type in the future should it be necessary to support more advanced features, although I can see that the intent is that those would be represented as new data types so maybe extensibility doesn't matter so much.

Are we really sure it is worth making this change? If nothing else, it will further delay the up-cpp API updates while we make this change.