search

eclipse-uprotocol / up-spec

uProtocol Specifications
Apache License 2.0
34 stars 25 forks source link

Configuration Sync among different UPClientZenoh implementations #95

Closed evshary closed 7 months ago

evshary commented 7 months ago

@MelamudMichael Would you please share the configuration for only UPClientZenoh? I think we need to sync between Rust and C++.

Now in Rust, I believe we only plan to initiate UPClientZenoh with UAuthority and UEntity, which is in @PLeVasseur's PR

After listing them, we should add them to the Zenoh spec.

PLeVasseur commented 7 months ago

Oh yes! This is actually a great place to ensure we're on the same page about that bit.

@stevenhartley has said in the past we need to be able to build a UUri internally for invoke_method(), so I added a UAuthority and UEntity to the constructor and what's held by the UPClientZenoh implementation.

I hope that made sense @evshary, @MelamudMichael :slightly_smiling_face:

PLeVasseur commented 7 months ago

@evshary -- do you wanna close this one in favor of #85?

evshary commented 7 months ago

Now we have two kinds of configurations to discuss:

  1. How to pass Zenoh configuration in the constructors
  2. What kinds of extra configuration UPClientZenoh needs for initialization

Maybe we can discuss these two in #85 if you think it can keep the issue list cleaner.