eclipse-uprotocol / up-streamer-rust

Generic uStreamer implementation written in Rust
Apache License 2.0
1 stars 4 forks source link

Error handling when register_listener fails #21

Open jjj-vtm opened 4 days ago

jjj-vtm commented 4 days ago

If register_listener fails there is only a log message

https://github.com/eclipse-uprotocol/up-streamer-rust/blob/d4ab17fbc745705290e29e5251fa8e9fcbffe943/up-streamer/src/ustreamer.rs#L153C1-L173

but the constructed tuple is added to forwarding_listeners and set to active. This basically leaves a "dead" listener in the HashMap.

PLeVasseur commented 4 days ago

Thanks for pointing this out! You're completely right :)