eclipse-uprotocol / up-transport-zenoh-cpp

C++ client library to connect to the zenoh implementation of uProtocol
Apache License 2.0
5 stars 15 forks source link

clang-tidy: issues in ZenohUTransportTest.cpp #100

Open debruce opened 2 months ago

debruce commented 2 months ago

1) do not use namespace using-directives; use using-declarations instead (line 23) 2) destructor should be annotated with override at line 40 3) unused variables: authority (line48) 4) TestBody has "cognitive complexity of 28 (threshold 25)". clang-tidy has failed the cognitive complexity test due to gtest macros, probably. This test case is as understandable as any. 5) Another bogus if-then-else complaint, but this time buried in gtest macros at line 84

clang-tidy was 95% useless on this gtest file.