Closed dennismeister93 closed 1 year ago
github-actions[bot]
commented
1 year ago 48 tests 42 :heavy_check_mark: 0s :stopwatch: 1 suites 6 :zzz: 1 files 0 :x:
Results for commit a03120be.
:recycle: This comment has been updated with latest results.
github-actions[bot]
commented
1 year ago
| File | Coverage | Lines | Branches | |
|---|---|---|---|---|
| All files | 39% |
46% |
32% |
:x: |
| velocitas_lib.py | 91% |
89% |
94% |
:white_check_mark: |
| src/install_deps.py | 0% |
0% |
0% |
:x: |
| src/app_deployment/build_vehicleapp.py | 0% |
0% |
0% |
:x: |
| src/app_deployment/deploy_vehicleapp.py | 0% |
0% |
0% |
:x: |
| src/runtime/controlplane.py | 0% |
0% |
0% |
:x: |
| src/runtime/runtime-down.py | 0% |
0% |
0% |
:x: |
| src/runtime/runtime-up.py | 0% |
0% |
0% |
:x: |
| src/runtime/runtime.py | 0% |
0% |
0% |
:x: |
| src/runtime/deployment/gen_helm.py | 36% |
44% |
27% |
:x: |
| src/runtime/deployment/gen_podspec.py | 44% |
53% |
35% |
:x: |
| src/runtime/deployment/lib.py | 22% |
35% |
10% |
:x: |
Minimum allowed coverage is 80%
Generated by :monkey: cobertura-action against c196e0d811278330586f9169f2f61217be2f07ff
MP91
commented
1 year ago I would like to discuss the file and folder-structure. It looks a bit unstructured to me...
Proposal: Move gen_helm.py, gen_podspec.py and lib.py into the deployment folder, move runtime-up and -down into the runtime folder, move all the files regarding the app into a new folder name app-deployment or similar.
What do you think @dennismeister93 , @BjoernAtBosch, @mml5bg, @doosuu ?
BjoernAtBosch
commented
1 year ago Good point. I mean, before AppManifest refactoring the src folder was empty and runtime did contain everything related to the runtime (except app) and deployment everything related to the app.
Starting from there I would argue, that in src all those things should be placed which is relevant for both subfolders.
BjoernAtBosch
commented
1 year ago I'm not sure if we should split the runtime deployment and runtime start/stop thingees ...
dennismeister93
commented
1 year ago I would like to discuss the file and folder-structure. It looks a bit unstructured to me...
Proposal: Move gen_helm.py, gen_podspec.py and lib.py into the deployment folder, move runtime-up and -down into the runtime folder, move all the files regarding the app into a new folder name app-deployment or similar.
What do you think @dennismeister93 , @BjoernAtBosch, @mml5bg, @doosuu ?
Somehow restructuring would be good! I would say go ahead with your proposal
This PR adds all changes for the new app manifest. Including: Porting all scripts to python with unit / integration tests