eclipse-velocitas / vehicle-app-python-sdk

vehicle-app-python-sdk
Apache License 2.0
7 stars 18 forks source link

[Bug]: SeatAdjuster App: ModuleNotFoundError: No module named 'vehicle' #79

Closed antaradey-itk closed 1 year ago

antaradey-itk commented 1 year ago

What happened?

SeatAdjuster App in Python SDK does not work anymore. Throws the following error. The application launcher works until v0.8.2.

seatadjuster_app_error

In the current version, import library changed from sdv_model to vehicle for examples/seatadjuster, and requirement-links.txt does not contain the sdv_model Github link anymore.

Please explain the issue.

Operating System

Linux

What release version or branch did you use?

v0.9.0: latest

Relevant log output

No response

Code of Conduct

BjoernAtBosch commented 1 year ago

Hi antaradey-itk, sorry, that's "by intention" currently - but unfortunately somewhat confusing, of course.

It's mentioned in the README.md, that this example is working via an import task from our vehicle-app-python-template, only (and repo instances created from the template, of course).

I guess, the mention in the readme isn't prominent enough. I will add a hint in the example itself as a "bugfix" for now.

The reason for that strange situation is, that we recently changed our provisioning of the vehicle model. Before (and still used by most examples in the SDKs) we used a pre-generated model from the respective model repository for Python or C++. But now in the template repositories we switched to generate the model directly from the source specified in the AppManifest when the devContainer is instantiated (or manually triggered by VS Code task). Unfortunately, both the models aren't fully compatible.

So the SeatAdjuster App of the Python SDK is the only example, which can be imported from Python template and is therefore not compatible to the old model used in the SDK.

It is planned to migrate the SDK repos to the new model generation approach, but currently it is unclear when this will happen.

Hope that information is helpful and best regards.

BjoernAtBosch commented 1 year ago

Hi @antaradey-itk , fix is provided with #85 and eclipse-velocitas/vehicle-app-python-template#160. Please have a look, if the solution seems sufficient for you. I will close this issue for now. Please re-open if further additions are required. Best regards