eclipse-velocitas / vehicle-app-python-template

Vehicle App template for Python
Apache License 2.0
17 stars 26 forks source link

[Bug]: Fix unspecific error messages during model lifecycle #191

Closed BjoernAtBosch closed 1 year ago

BjoernAtBosch commented 1 year ago

Severity

Medium

What release version, tag or commit-hash did you use?

2ed763a60c8895ad16f152ab0d6444c9e965003b

Current Behavior

If referencing a non-existing vss.json from the AppManifest.json and calling velocitas init -f the model lifecycle has this misleading output:

... > Running post init hook for 'vehicle-model-lifecycle'
Running 'install-deps'... done
Running 'download-vspec'... done
Running 'generate-model'... !
 ›   Error: Program returned exit code: 1

Misleading, because the download-vspec should drop the error and not the generate-model.

Also, there is unspecific message if a non-supported VSS version is used (e.g. VSS version 4.0 at the moment).

Also, if model lifecycle fails during devContainer setup, the failure is not clearly visualize and could be quite easily overseen. This seems especially the case if using GH Code Space.

Steps to Reproduce

  1. Change VSS reference in AppManifest to non-existing file
  2. Run velocitas init -f

Expected Behavior

Error messages should clearly point out what the issue is

Possible Solution

No response

Additional Information

No response

Code of Conduct

BjoernAtBosch commented 1 year ago

One fix should be done here: https://github.com/eclipse-velocitas/devenv-devcontainer-setup/blob/main/vehicle-model-lifecycle/src/download_vspec.py#L75

BjoernAtBosch commented 1 year ago

Wrong repo. Created same issue here: https://github.com/eclipse-velocitas/devenv-devcontainer-setup/issues/34