search

eclipse-vertx / vert.x

Vert.x is a tool-kit for building reactive applications on the JVM
http://vertx.io
Other
14.31k stars 2.08k forks source link

CompositeFuture forces you to use raw types #2058

Open ctron opened 7 years ago

ctron commented 7 years ago

There are currently three methods in CompositeFuture which force you to use raw types:

The causes compiler warnings to appear all over the place:

image

It should be possible to rewrite the method signature to e.g. io.vertx.core.CompositeFuture.all(List<Future<?>>), which solves the raw types warning, but is not compatible with the previous declaration and this would break compatibility.

However there could be be a set of workarounds. One could be simply adding new methods like e.g. allOf. Or putting everything in a new interface TypedCompositeFuture, which would avoid the collision.

jan-zajic commented 7 years ago

See Closed PR #1994 with discussion

tmbull commented 2 years ago

Per discussion on #3595, it sounds like this can be fixed now?

vietj commented 2 years ago

yes, we had an attempt but it creates breaking change, so the consensus would be to copy the relevant methods to Future and deprecate the others

On Thu, Dec 2, 2021 at 10:58 PM Tristan Bull @.***> wrote:

Per discussion on #3595 https://github.com/eclipse-vertx/vert.x/pull/3595, it sounds like this can be fixed now?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/eclipse-vertx/vert.x/issues/2058#issuecomment-985034491, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXDCV3TZT4KZWH7GPHBGDUO7TZNANCNFSM4DTMQVVQ .

lukasalexanderweber commented 1 year ago

@vietj are there any updates on this? :)

vietj commented 1 year ago

that shall be a vertx 5 item

On Tue, Feb 14, 2023 at 9:02 AM Lukas Weber @.***> wrote:

@vietj https://github.com/vietj are there any updates on this? :)

— Reply to this email directly, view it on GitHub https://github.com/eclipse-vertx/vert.x/issues/2058#issuecomment-1429292272, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXDCW2CYTGFO7E6NKLD4TWXM323ANCNFSM4DTMQVVQ . You are receiving this because you were mentioned.Message ID: @.***>

lukasalexanderweber commented 1 year ago

@vietj I just happened to see that this seems to be solved: https://github.com/vert-x3/vertx-web/commit/e299227694b48246beda152b1cfea60f129b9d7d