search

eclipse-vertx / vert.x

Vert.x is a tool-kit for building reactive applications on the JVM
http://vertx.io
Other
14.25k stars 2.07k forks source link

Doc typo at https://vertx.io/docs/guide-for-java-devs/ Wiki verticle initialization phases: void -> Void #3505

Open based2 opened 4 years ago

based2 commented 4 years ago

Questions

Do not use this issue tracker to ask questions, instead use one of these channels. Questions will likely be closed without notice.

Version

3.9.2 - current Web site

Context

https://vertx.io/docs/guide-for-java-devs/ Wiki verticle initialization phases

Do you have a reproducer?

https://vertx.io/docs/guide-for-java-devs/ Wiki verticle initialization phases

Steps to reproduce

  1. https://vertx.io/docs/guide-for-java-devs/ Wiki verticle initialization phases
  2. Promise promise = Promise.promise(); should be Promise promise = Promise.promise();
  3. ...
  4. ...

Extra

julianladisch commented 3 years ago

The typo

Promise<void> promise = Promise.promise();

has be been fixed to

Promise<Void> promise = Promise.promise();

in commit https://github.com/vert-x3/vertx-guide-for-java-devs/commit/0ed960ba27b4a0415d3ad884092caf96e0b2cc52 that has been merged to default branch 3.8 but not to branch master. This fix has not been deployed to https://vertx.io/docs/guide-for-java-devs/ yet.