Support duplicated context duplication

eclipse-vertx / vert.x

Vert.x is a tool-kit for building reactive applications on the JVM

http://vertx.io

Other

14.32k stars 2.08k forks source link

Support duplicated context duplication #5215

Open vietj opened 5 months ago

vietj commented 5 months ago

Duplicating a duplicated context is supported but the semantic of the actual locals is not defined.

This update the duplicated context duplication by doing a copy of each local in the duplicated duplicate. This introduce a duplicator for each local that is responsible for copying the object when it is not null.

[ ] Periodic tasks should duplicate a duplicated context using this API ?

vietj commented 5 months ago

@franz1981 @cescoffier please have a look

franz1981 commented 5 months ago

This can be related (and better used at) https://github.com/quarkusio/quarkus/pull/40725

can you checkout my branch there and show how the changes there will translate with the new API, bud? I'm travelling, but I would like, before it got merged, to make sure the semantic and behaviours won't change too much and instead we save some code by leveraging this new feature (which is super cool!)

vietj commented 5 months ago

for now this is a tentative PR, we can discuss next week @franz1981 I think

franz1981 commented 5 months ago

Yep, let's sync once I'm back, thanks @vietj :pray: