eclipse-vertx / vert.x

Vert.x is a tool-kit for building reactive applications on the JVM
http://vertx.io
Other
14.26k stars 2.07k forks source link

Apache Ignite Cluster Manager: Add possibility to customize messageQueueLimit via ignite.json #5228

Closed scyv closed 3 months ago

scyv commented 3 months ago

Using Apache Ignite as Cluster Manager, it is (as far as i could see in the code) not possible to overwrite the property messageQueueLimit as io.vertx.spi.cluster.ignite.IgniteOptions is missing the mapping for it.

Not defining the limit leads to a (valid) message on the console:

System.out:
org.apache.ignite.IgniteLogger - Message queue limit is set to 0 which may lead to potential OOMEs when running cache operations in FULL_ASYNC or PRIMARY_SYNC modes due to message queues growth on sender and receiver sides.

So it would be good to have the possibility to set the limit via the ignite.json file like:

ignite.json:
{
  "messageQueueLimit": 1024,     <-- here
  "discoverySpi": {... },
  "cacheConfiguration": [...],
  "metricsLogFrequency": 0,
  "shutdownOnSegmentation": true
}

If this is found eligible, i volunteer implementing this.

Thanks and Best Regards!

scyv commented 3 months ago

sorry, i think this was the wrong repo. I reposted the issue here: https://github.com/vert-x3/vertx-ignite/issues/140