HAManager couldn't see quorum if during its initialization cluster manager has all nodes joined already #5272

[apanasevich]

Fixes #5272

The key idea is to wait until clusterMap get information from other nodes like it done in nodeAdded method.

[vietj]

@apanasevich can you provide a reproducer for this or add a test demonstrating where this is useful ?

[apanasevich]

Hi @vietj

I cannot reproduce a bug. The problem occures when clusterManager.getNodes(); contains a node, but clusterMap.get(node); do not yet. And this case is covered with timered check in method checkQuorumWhenAdded, but not covered on init.

      List<String> nodes = clusterManager.getNodes();
      int count = 0;
      for (String node : nodes) {
        String json = clusterMap.get(node);

I'll try to write a test covering the issue.

[apanasevich]

I've written the test with a special ClusterManager emulating the issue behaviour. It does not call nodeAdded listerens that looks like cluster was created before Vert.x initiates HAManager.

Please take a look at the PR again.

[vietj]

thanks @apanasevich

[apanasevich]

NetTest.testSocketAddress timed out. But this test does not use HA feature and even does not deploy a verticle.

[vietj]

@apanasevich there are some flaky tests, I reran the CI