eclipse-vertx / vert.x

Vert.x is a tool-kit for building reactive applications on the JVM
http://vertx.io
Other
14.26k stars 2.07k forks source link

Client metrics decoupling from pool metrics #5277

Closed vietj closed 1 month ago

vietj commented 1 month ago

The client metrics exposes enqueue/dequeue operation coupling the pooling/queuing aspect of a client to the interaction metrics, among relevant issues a client is forced to obtain a client metrics instance before logging any interaction with the pool which does not practically works when the pool can interact with a client resolved at connection time (from the pool perspective).

The queuing metrics portion has been decoupled from the pool metrics, so it can be reused independently (e.g. the WebSocket client has a wait queue but does not use a pool).

This is an SPI breaking change as well as a reported metrics breaking change, user facing API changes should be documented by metrics implementation.