search

eclipse-vertx / vertx-auth

Apache License 2.0
160 stars 153 forks source link

fix: ensure access_token is available after introspect #660

Closed chrispatmore closed 11 months ago

chrispatmore commented 1 year ago

Update the code to ensure the access token is available after validating the token using token introspect

Motivation:

Contributes to: https://github.com/eclipse-vertx/vertx-auth/issues/659

chrispatmore commented 1 year ago

I would prefer not to put the token introspect response JSON as the principal JSON as I don't think they're really the same thing, and I have seen (Keycloak for example) returns username as well as sub and then when that json is placed as the principal (not under idToken or other) the User created returns the username as the subject() instead of the sub which is what is returned if the token validates / if there is an idToken

But. I can see that being a breaking change for those relying on it behaving as is at the moment, so I could accept that I just have to include a workaround to fix the subject post authentication

pmlopes commented 11 months ago

We can accept this behavior change as we are targetting to 5.0.0