search

eclipse-vertx / vertx-auth

Apache License 2.0
160 stars 153 forks source link

Wrong initialization of jwtOptions field in OAuth2Options #663

Closed weery28 closed 2 months ago

weery28 commented 11 months ago

Version

4.4.1

Context

I encountered an exception which looks suspicious while create more than one instance of OAuth2Options. jwtOptions initialized by object in static field, then we have the same object in every OAuth2Options instance.

https://github.com/eclipse-vertx/vertx-auth/blob/master/vertx-auth-oauth2/src/main/java/io/vertx/ext/auth/oauth2/OAuth2Options.java#L51

This line should not exist. A new instance should be created here:

https://github.com/eclipse-vertx/vertx-auth/blob/master/vertx-auth-oauth2/src/main/java/io/vertx/ext/auth/oauth2/OAuth2Options.java#L174

vietj commented 2 months ago

@weery28 I need a contributor agreement to be signed on the PR

tsegismont commented 2 months ago

Duplicated by https://github.com/eclipse-vertx/vertx-auth/issues/676