search

eclipse-vertx / vertx-auth

Apache License 2.0
162 stars 154 forks source link

Fix the length of the curveID #685

Closed aelamrani closed 2 weeks ago

aelamrani commented 3 weeks ago

Fixes https://github.com/eclipse-vertx/vertx-auth/issues/684 According to TPM 2.0 documentation, curveID has length of 2 bytes. This causes problem with reading length of unique.

tsegismont commented 3 weeks ago

Can you please make sure to sign the Eclipse contributor agreement and sign-off your commit (with git commit -s) ?

Thank you

tsegismont commented 3 weeks ago

Also, can you please add a test? Obviously this wasn't caught by our test suite so it would be great to improve it.

aelamrani commented 2 weeks ago

@podlesrafal leaving it to you