search

eclipse-vertx / vertx-auth

Apache License 2.0
166 stars 156 forks source link

COSE algorithm enum should be renamed from `PublicKeyCredential` #699

Open ynojima opened 1 week ago

ynojima commented 1 week ago

https://github.com/eclipse-vertx/vertx-auth/blob/f0f869b20a116dc17dc2cfd204705a83048982ff/vertx-auth-webauthn/src/main/java/io/vertx/ext/auth/webauthn/PublicKeyCredential.java#L25

This seems from vertx-auth-webauthn, but COSE algorithm enum should be renamed from PublicKeyCredential. WebAuthn standard uses the name PublicKeyCredential for other type. COSE algorithm type should be COSEAlgorithm or COSEAlgorithmIdentifier. https://www.w3.org/TR/webauthn-3/#typedefdef-cosealgorithmidentifier