eclipse-vertx / vertx-codegen

Vert.x code generator for asynchronous polyglot APIs
Apache License 2.0
105 stars 92 forks source link

Ignore type annotations when searching for serializers / deserializers #316

Closed zenios closed 3 years ago

zenios commented 3 years ago

Signed-off-by: Dimitris Zenios dimitris.zenios@gmail.com

When a type included an annotation such as @NonNull then TypeMirrorFactory tried to find a mapper using type.toString().

type.toString() included the annotation in the name as well which resulted in failing to find the appropriate mapper.

With these change the serializers / deserializers are found using the fqdn of the type only

vietj commented 3 years ago

the test does not fail @zenios , I think there should be a failing test

zenios commented 3 years ago

the test does not fail @zenios , I think there should be a failing test

@vietj If you remove the fix on TypeMirrorFactory it will fail

vietj commented 3 years ago

oh right, I thought you were only providing a failing test.

can you edit the PR description to describe what was wrong and what you changed ?

zenios commented 3 years ago

oh right, I thought you were only providing a failing test.

can you edit the PR description to describe what was wrong and what you changed ?

@vietj Done