search

eclipse-vertx / vertx-codegen

Vert.x code generator for asynchronous polyglot APIs
Apache License 2.0
105 stars 92 forks source link

Fix regression for Kotlin companion objects #329

Closed rgmz closed 3 years ago

rgmz commented 3 years ago

This is a duplicate of #229, which went stale and had a messy commit history.

Simple workaround for vert-x3/vertx-lang-kotlin#93.

LMK if there's a better/more appropriate fix.

FYI @vietj

vietj commented 3 years ago

@rgmz I updated the isValidKotlinCompanionObject method in master. My earlier comment about checking the type was actually a simplistic view of this.

rgmz commented 3 years ago

Thanks @vietj, that's a much better implementation!

On Wed., May 5, 2021, 8:49 a.m. Julien Viet, @.***> wrote:

@rgmz https://github.com/rgmz I updated the isValidKotlinCompanionObject method in master. My earlier comment about checking the type was actually a simplistic view of this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-codegen/pull/329#issuecomment-832660019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHVFC7X5NHBC5U34RSMLBLDTME5FFANCNFSM43GSWFFQ .