search

eclipse-vertx / vertx-codegen

Vert.x code generator for asynchronous polyglot APIs
Apache License 2.0
105 stars 92 forks source link

Future returning signature for codegen #332

Closed vietj closed 3 years ago

vietj commented 3 years ago

see also

vietj commented 3 years ago

@slinkydeveloper please have a look

vietj commented 3 years ago

Keep in mind this is an internal API

On Thu, Apr 29, 2021 at 2:59 PM Francesco Guardiani < @.***> wrote:

@.**** commented on this pull request.

In src/main/java/io/vertx/codegen/MethodKind.java https://github.com/vert-x3/vertx-codegen/pull/332#discussion_r623027540:

* is a parameterized handler type having a <i>async_result</i> parameterized type argument.

*/

  • CALLBACK,

I see what you mean, but for somebody that doesn't know the vert.x details like the one you sad, both Handler and Handler<AsyncResult> looks like callbacks, hence the term IMO is too generic. While ASYNC_HANDLER clearly identify Handler<AsyncResult>

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-codegen/pull/332#discussion_r623027540, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXDCSP5ZDAXAH4ZWLIDXLTLFJ27ANCNFSM43U46V3A .