search

eclipse-vertx / vertx-codegen

Vert.x code generator for asynchronous polyglot APIs
Apache License 2.0
105 stars 92 forks source link

support default kapt builds #347

Closed BFergerson closed 2 years ago

BFergerson commented 2 years ago

Motivation:

fixes https://github.com/eclipse-vertx/vertx-codegen/issues/346

I couldn't find a dynamic solution to all Kapt builds so I created a solution that strictly solves default Kapt setups. It fixes the problem I mention in #346 and could be expanded for more setups.

vietj commented 2 years ago

thanks, is there a way to add a test for this ? I'm afraid to introduce regressions when this code would be changed

BFergerson commented 2 years ago

What would a test look like? As for the regressions, it should be safe considering it looks for kapt.kotlin.generated before doing anything and you previously hinted Kapt wasn't exactly supported.

Perhaps instead of this, a new property could be introduced? Something like vertx.codegen.json-mappers-location? If that property isn't found then nothing happens. If it's found, it'll try that location for json-mappers.properties. Should be no chance of regression there.

vietj commented 2 years ago

thanks @BFergerson