search

eclipse-vertx / vertx-codegen

Vert.x code generator for asynchronous polyglot APIs
Apache License 2.0
105 stars 92 forks source link

DataObject property name #348

Open hammettj opened 2 years ago

hammettj commented 2 years ago

As I'm constantly dealing with JSON documents which contain Java keywords or illegal characters I always have to work around this problem. This might not be a problem for a handful of classes but gets very time-consuming, error-prone and complex if you have to support multiple versions of a data exchange protocol or similar.

There have been several attempts to add per-property naming for DataObjects from different developers, but none of those made it to master.

With this Pull Request it would be possible to annotate a specific property like so:

@DataObject.Property(":ref")
public String getRef() {
    return ref;
}

The generated converter will then pick up the specified property name instead of the default one determined by the jsonPropertyNameFormatter.

hammettj commented 1 year ago

Hello @vietj. I'm sorry to bother you. I just wanted to ask if you already had a chance to take a look at the changes?