search

eclipse-vertx / vertx-grpc

Development of the gRPC component for Eclipse Vert.x
Eclipse Public License 2.0
43 stars 23 forks source link

When client.request failed, throw the exception #16

Closed rxf113 closed 2 years ago

rxf113 commented 2 years ago

fix bug #15

tsegismont commented 2 years ago

cc @vietj

vietj commented 2 years ago

Can you add a test ?

rxf113 commented 2 years ago

Can you add a test ?

I added a test, and There are some other changes, please confirm carefully

rxf113 commented 2 years ago

Can you add a test ?

I added a test, and There are some other changes, please confirm carefully

Added a test sample vertx-grpc-server-unavailable

vietj commented 2 years ago

the test has been removed, can you elaborate ?

rxf113 commented 2 years ago

the test has been removed, can you elaborate ? I added a test sample vertx-grpc-server-unavailable

The previous test shouldn't be there because it needs to depend on VetxStub and I had to modify the pom.xml, which I don't think is a qualifying unit test, so i removed it

rxf113 commented 2 years ago

Updated description： https://github.com/rxf113/vertx-grpc-server-unavailable/blob/main/README.md

rxf113 commented 2 years ago

Updated description： https://github.com/rxf113/vertx-grpc-server-unavailable/blob/main/README.md

vietj commented 2 years ago

thanks, I ported the code here in the more general PR about vertx client call error handling : https://github.com/eclipse-vertx/vertx-grpc/pull/19