search

eclipse-vertx / vertx-grpc

Development of the gRPC component for Eclipse Vert.x
Eclipse Public License 2.0
37 stars 23 forks source link

Add GrpcClientRequestOptions to pass timeout #64

Closed liuchong closed 7 months ago

liuchong commented 1 year ago

Motivation:

I want to pass timeout option when request grpc server with client, so added a new GrpcClientReqesatOptions class to impl it. In future maybe we could add more options into it from io.vertx.core.http.RequestOptions

liuchong commented 1 year ago

Could you please check that if we need this when you have time? @vietj @tsegismont 👀

vietj commented 1 year ago

I'll have a look

vietj commented 10 months ago

can you add a test for this @liuchong ?

liuchong commented 10 months ago

ok I will do 👀

liangyuanpeng commented 8 months ago

It would be resolve the issue https://github.com/eclipse-vertx/vertx-grpc/issues/37 , right?

It's not true, #37 is talking ablout server side and this PR is work for client.

vietj commented 7 months ago

see the idle timeout and the deadline & timeout PR

liuchong commented 7 months ago

ok, I fount then in #79 and #78, seems using the logic we've talked before, thanks! 👀