search

eclipse-vertx / vertx-grpc

Development of the gRPC component for Eclipse Vert.x
Eclipse Public License 2.0
37 stars 23 forks source link

[4.x] update javax to Jakarta #73

Closed liangyuanpeng closed 8 months ago

liangyuanpeng commented 8 months ago

Motivation:

Explain here the context, and why you're making that change, what is the problem you're trying to solve.

Upgrade to jakarta-annotation-api, javax.annotation-api has been deprecated

related: https://github.com/etcd-io/jetcd/issues/1243

Conformance:

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

liangyuanpeng commented 8 months ago

May related:

vietj commented 8 months ago

unfortunately that does not work because the protoc plugin will regenerate the javax.annotation.Generated annotation in the source code defeating the purpose of this PR. It seems also that the grpc-java project is not willing to provide an alternative for building with a jakarta annotation.