search

eclipse-vertx / vertx-http-proxy

vertx http proxy
Eclipse Public License 2.0
55 stars 36 forks source link

add tests for special websocket upgrade request #61

Closed machine424 closed 9 months ago

machine424 commented 9 months ago

Motivation:

See: https://github.com/eclipse-vertx/vertx-http-proxy/issues/62

Conformance:

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

vietj commented 9 months ago

So we expect this new test to fail ?

machine424 commented 9 months ago

I rebased to get your latest fixes regarding parseHostAndPort

Yes testWebSocketMultiValueConnHeader should fail, testWebSocketUniqueValueConnHeader is just a "positive control" and we'll get rid of it.

tsegismont commented 9 months ago

@machine424 can you please sign the Eclipse Contributor Agreement and sign-off your commits? Thanks

tsegismont commented 9 months ago

Superseded by #63

tsegismont commented 9 months ago

Thank you @machine424

I went ahead and sent #63 because we'd like to release 4.5.3 today