search

eclipse-vertx / vertx-http-proxy

vertx http proxy
Eclipse Public License 2.0
55 stars 36 forks source link

Ignore host header in proxied request regardless it's casing #79

Closed joelholzerxovis closed 5 months ago

joelholzerxovis commented 5 months ago

Resolves #77

Motivation: I encountered an edge case which is not handled properly. The method sendRequest in the class ProxiedRequest ignores on line 173 the "host" header. In our application, I encountered the issue, that the "Host" header is starting with an Uppercase letter. Therefore it is added to the request on line 174, but it shouldn't.

This fix ignores the host header regardless it's casing.

tsegismont commented 5 months ago

Can you please create the same PR for the main branch?

joelholzerxovis commented 5 months ago

Can you please create the same PR for the main branch?

Hi @tsegismont

I have created a PR for the main branch -> https://github.com/eclipse-vertx/vertx-http-proxy/pull/82

Thank you for reviewing it.