search

eclipse-vertx / vertx-http-proxy

vertx http proxy
Eclipse Public License 2.0
55 stars 36 forks source link

update HTTP caching #93

Open wzy1935 opened 4 months ago

wzy1935 commented 4 months ago

Refers to issue #70.

Major changes in CacheFilter.java, implemented 1, 2, 3, 4, 5 (partial), 6, 8, 9. (Implement 6 evolves with parts of 1 and 4 so they need to be done as well)

No test has been added/updated so far, so running the test will fail since the cache has different behaviors.

tsegismont commented 4 months ago

The PR seems to contain a commit that is not related (caching SPI change). Correct? In this case, can you please rebase your branch on the main branch?

wzy1935 commented 4 months ago

It's somehow related since it uses the async version of the cache API. I think we could rebase this one after merging #92 (that one is in progress) ?

tsegismont commented 4 months ago

It's somehow related since it uses the async version of the cache API. I think we could rebase this one after merging #92 (that one is in progress) ?

Does it require the Cache SPI changes or is it just because you started this PR off of your Cache SPI branch?

wzy1935 commented 4 months ago

I started it on the SPI branch - it can be reversed to the original cache API, but it will just look a bit different.

tsegismont commented 4 months ago

I started it on the SPI branch - it can be reversed to the original cache API, but it will just look a bit different.

Then yes, it's fine to rebase this one after #92 is merged