eclipse-vertx / vertx-junit5

Testing Vert.x applications with JUnit 5
Apache License 2.0
44 stars 32 forks source link

Bumping to 5.8.2 #112

Closed matzew closed 2 years ago

matzew commented 2 years ago

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Motivation:

using the latest of junit jupiter Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

matzew commented 2 years ago

I've contributed to vert.x before: https://github.com/vert-x3/vertx-kafka-client/commits?author=matzew

matzew commented 2 years ago

I updated the commit, using my Apache email address - which I think I used for Eclipse (instead of my RHT one)

matzew commented 2 years ago

@vietj @jponge any idea on this "ECA" thing? or mind to do the bump yourself

jponge commented 2 years ago

Most likely the Eclipse bot not recognising your email as that of an Eclipse Contributor.

You have 2 options:

matzew commented 2 years ago

@jponge I have now signed it via the Red Hat Email. And I have done contributions to vert.x before (as a RHT employee), so I must be covered, one way or the other

jponge commented 2 years ago

Great!

jponge commented 2 years ago

I'll ignore that ECA check