eclipse-vertx / vertx-junit5

Testing Vert.x applications with JUnit 5
Apache License 2.0
42 stars 30 forks source link

Rename checkpoint() to laxCheckpoint(), rename strictCheckpoint() to checkpoint() #50

Closed julianladisch closed 5 years ago

julianladisch commented 5 years ago

The vast majority of asynchronous implementations require a strict checkpoint. Therefore the default checkpoint() function should return a strict checkpoint.

This is an API change that may break existing code. However, https://vertx.io/docs/vertx-junit5/java/ says: "Warning | This module has Tech Preview status, this means the API can change between versions."

julianladisch commented 5 years ago

Thanks @jponge, I've reviewed the 4 files in src/main/asciidoc and src/main/java/examples:

jponge commented 5 years ago

Ok thanks @julianladisch .

How about #49 and this BTW?

julianladisch commented 5 years ago

49 and this pull request are independent of each other. There javadoc of #49 is still correct if this pull request gets merged.