eclipse-vertx / vertx-junit5

Testing Vert.x applications with JUnit 5
Apache License 2.0
44 stars 32 forks source link

Better checkpoint diagnostics #72

Closed jponge closed 4 years ago

jponge commented 4 years ago

Provide a diagnostic of unsatisfied checkpoints call sites

This inspects the call stack when a checkpoint is being created to find the most likely call site in user code.

Fixes #67

jponge commented 4 years ago

Waiting from @tombentley @slinkydeveloper before I merge

jponge commented 4 years ago

Or Set? :-)

On 3 Jan 2020, at 10:11, Tom Bentley notifications@github.com wrote:

@tombentley commented on this pull request.

In vertx-junit5/src/main/java/io/vertx/junit5/VertxTestContext.java:

@@ -79,6 +81,19 @@ public synchronized boolean completed() { return !failed() && releaseLatch.getCount() == 0; }

  • /**
    • Gives the call sites of all unsatisifed checkpoints.
  • *
    • @return a list of {@link StackTraceElement} references pointing to the unsatisfied checkpoint call sites.
  • */
  • public List unsatisfiedCheckpointCallSites() {

Personally I would use Collection or Iterable, but I guess List is fine.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.