eclipse-vertx / vertx-junit5

Testing Vert.x applications with JUnit 5
Apache License 2.0
42 stars 30 forks source link

Fix missing onFailure, unit test examples.* #76

Closed julianladisch closed 4 years ago

julianladisch commented 4 years ago

.onSuccess( is used without accompanying .onFailure( several times resulting in missing error reporting in case of failure. To provide the reader with complete examples the problem is fixed by converting .onSuccess( to .onComplete(testContext.succeeding(.

For consistency the one example where both .onSuccess( and .onFailure( exist is also converted.

The missing responsesReceived.flag() is added to the checkpointing example to make it succeed.

To catch any future regressions the classes in examples directory have been added to unit testing.

The comment in ETest is split into two lines to prevent ugly line wrapping by browsers with big font size.

Signed-off-by: Julian Ladisch eclipse.org-rtn@ladisch.de

jponge commented 4 years ago

Thanks!