search

eclipse-vertx / vertx-sql-client

High performance reactive SQL Client written in Java
Apache License 2.0
891 stars 199 forks source link

Correct handling of SSL mode always for PostgreSQL #1413

Closed vietj closed 7 months ago

pendula95 commented 7 months ago

I am not able to evaluate but now this changes the behavior of https://github.com/eclipse-vertx/vertx-sql-client/blob/a2d2f9002a5fce562c8236c3310faad98038bb0d/vertx-pg-client/src/main/java/io/vertx/pgclient/impl/PgConnectionFactory.java#L86-L95

Previously canceled requests did not send Startup. For this I suggest pass a flag cancelRequest

vietj commented 7 months ago

@pendula95 a couple of concerns raised

pendula95 commented 7 months ago

You are quite right, I have corrected everything here: https://github.com/eclipse-vertx/vertx-sql-client/pull/1421

Sorry for creating additional PRs but as I dont have permissions to directly commit here I dont see any other way

vietj commented 7 months ago

@pendula95 don't be sorry, that's how it is supposed to be done

pendula95 commented 7 months ago

https://github.com/eclipse-vertx/vertx-sql-client/pull/1422