eclipse-vertx / vertx-sql-client

High performance reactive SQL Client written in Java
Apache License 2.0
877 stars 195 forks source link

MS SQL uri parser does not parse JDBC urls #947

Open tsegismont opened 3 years ago

tsegismont commented 3 years ago

With the Postgres and MySQL clients, you can take a connection URI that works with JDBC drivers and parse with the Reactive client parser.

I haven't checked for DB2 but this does not work with MSSQLConnectOptions.fromUri.

See https://docs.microsoft.com/en-us/sql/connect/jdbc/building-the-connection-url

vietj commented 3 years ago

this is expected for the moment we don't parse JDBC urls

vietj commented 3 years ago

if we were to do it, then we would do it globally

tsegismont commented 3 years ago

@vietj indeed we don't commit to being able to parse any JDBC url.

But for Postgres and MySQL, most common urls are the same in JDBC and reactive clients. For MS SQL, we took the same format as Postgres and MySQL, but Microsoft uses values separated by semi-colons.

rdruss commented 2 years ago

Looks like this may be related to #1118

tsegismont commented 2 years ago

@rdruss yes, it's a similar issue