Span timings aren't collected in case of any 5xx error

[nitishgoyal13]

Questions

Span timings aren't getting collected in case of any 5xx error.

Version

4.0.0

Happening consistently with all the spans with error

[vietj]

do you have a reproducer ? it is possible that some span are ignored by the tracing tool if you are using sampling

[nitishgoyal13]

A span without the duration field is causing the issue

{
  "traceId": "e101cf9a6eaa3755",
  "parentId": "e101cf9a6eaa3755",
  "id": "f610c17b720d6343",
  "kind": "SERVER",
  "name": "publish",
  "localEndpoint": {
    "serviceName": "xxx",
    "ipv4": "a.b.c.d"
  },
  "shared": true
}

In case of 5xx, I am always seeing one span with name = "publish" and this is always without duration. And this span is causing UI not to render the entire trace.

I delete the span with empty duration field and the trace is now visible in the UI

[nitishgoyal13]

This span with empty duration is getting created in ZipkinTracer class and receiveRequest method with operation as publish

[nitishgoyal13]

For now, I have done this as a workaround

if (policy == TracingPolicy.IGNORE || operation.equalsIgnoreCase("publish")) {
      return null;
    }

[vietj]

do you have a reproducer ?

[tsegismont]

Missing reproducer