Tracing: more eventbus and HTTP tags

eclipse-vertx / vertx-tracing

Vertx integration with tracing libraries

Other

41 stars 34 forks source link

Tracing: more eventbus and HTTP tags #67

Closed Olamshin closed 9 months ago

Olamshin commented 10 months ago

Version

4.4.6

Context

According to the document here, the following span attribute should be present for HTTP server spans.

http.scheme
http.target
net.host.name
net.host.port

Absence of these attributes would mean OTel spans from vert.x may not be categorized as HTTP spans by a telemetry backend.

tsegismont commented 10 months ago

Thanks for the report, @Olamshin

Would you like to contribute the fix?

Olamshin commented 10 months ago

@tsegismont Yes, i can attempt this. Looks like the core changes would here? Any other tips would be appreciated!

tsegismont commented 10 months ago

@tsegismont Yes, i can attempt this. Looks like the core changes would here? Any other tips would be appreciated!

Yes, I would start here. Then we need to make sure we don't break other tracing implementations

vietj commented 10 months ago

we should keep the actual names and translate them in vertx open tracing when it get the tags. if there are missing tags then we should add them using the same convention

tsegismont commented 9 months ago

Resolved by https://github.com/eclipse-vertx/vert.x/pull/5024