Open eclipse-viatra-bot opened 5 months ago
By Abel Hegedus on May 23, 2018 04:59
Created attachment 274142 NPE on selection changes
:notepad_spiral: file_534993.txt
By Abel Hegedus on May 23, 2018 04:59
Created attachment 274143 Exception at initialization or around there
:notepad_spiral: file_534993.txt
May 25, 2018 09:39
New Gerrit change created: https://git.eclipse.org/r/123337
May 25, 2018 09:39
New Gerrit change created: https://git.eclipse.org/r/123338
By Zoltan Ujhelyi on May 25, 2018 09:43
This issue contains multiple stack traces that are based on multiple issues.
1) The rebind graph view functionality does not work as expected for GEF 5 graphs. 2) The demonstrator perspective rebinds the all contents if the editor is selected; this should be replaced by rebinding only if a different editor is selected than before. 3) The view parts should remove themselves as PartListeners.
Given that fixing all these separate issues takes time (and requires changes in the VIATRA Viewers feature separately, for 2.0 the corresponding plug-in is removed from the demonstrator application; and this can be put back if all related issues are fixed.
May 31, 2018 10:16
Gerrit change https://git.eclipse.org/r/123338 was merged to [master].\ Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.examples.git/commit/?id=cd4f041af61d163832c31e5a660c9b6b039e21f1
May 31, 2018 10:16
Gerrit change https://git.eclipse.org/r/123337 was merged to [master].\ Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.examples.git/commit/?id=f8e81dc2fc03412b7811adcb770e3223d445208d
Jun 13, 2018 05:25
Gerrit change https://git.eclipse.org/r/123336 was merged to [master].\ Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=8fea46545771dc8e5eb34b3436f358396ec15bdb
By Zoltan Ujhelyi on Aug 07, 2018 04:27
Fixes are already done, after some testing we should decide whether we want to re-add the CPS perspective to the demonstrator.
| --- | --- | | Bugzilla Link | 534993 | | Status | NEW | | Importance | P3 normal | | Reported | May 23, 2018 04:58 EDT | | Modified | Dec 07, 2020 12:55 EDT | | Version | 2.0.0 | | Blocks | 519825 | | See also | Gerrit change https://git.eclipse.org/r/123337, Gerrit change https://git.eclipse.org/r/123338, Git commit cd4f041a, Git commit f8e81dc2, Gerrit change https://git.eclipse.org/r/123336, Git commit 8fea4654 | | Reporter | Abel Hegedus |
Description
The following errors are thrown by the views in CPS Perspective (assuming a CPS instance model is open in the editor in focus):
java.lang.IllegalArgumentException: node not on this layer\ at org.eclipse.gef.layout.algorithms.SpaceTreeLayoutAlgorithm$SpaceTreeLayer.moveNodeBackward(SpaceTreeLayoutAlgorithm.java:668)\ [...]\ org.eclipse.viatra.integration.zest.viewer.ZestContentViewer.refresh(ZestContentViewer.java:662)
Details attached.
The following exception seems to be thrown every time the selection changes even after the perspective and the views are closed.
java.lang.NullPointerException\ at org.eclipse.gef.mvc.fx.behaviors.ContentBehavior.synchronizeContentPartChildren(ContentBehavior.java:451)\ [...]\ org.eclipse.viatra.integration.zest.viewer.ZestContentViewer.refresh(ZestContentViewer.java:662)
It seems like the CPS views do not unregister their listeners even after the view is disposed.