eclipse-viatra / org.eclipse.viatra

Main components of the VIATRA framework
https://eclipse.dev/viatra
Eclipse Public License 2.0
0 stars 1 forks source link

In ViatraQueryTest builder the actual and expected values can be accidentally mixed up #134

Open eclipse-viatra-bot opened 3 months ago

eclipse-viatra-bot commented 3 months ago

| --- | --- | | Bugzilla Link | 578240 | | Status | UNCONFIRMED | | Importance | P3 normal | | Reported | Jan 17, 2022 05:14 EDT | | Modified | Jan 17, 2022 05:14 EDT | | Reporter | Benedek Horvath |

Description

At the moment, in the ViatraQueryTest builder the with method sets both the actual and the expected result, depending on the order in which it is called. The first call of the with sets the actual result and the second call set the expected result.

From the API user's perspective it would be better if there were different method for setting the actual and the expected results, e.g. withExpected, withActual, to avoid confusion.